Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheels are not being built #205

Closed
tomwhite opened this issue Jul 19, 2021 · 16 comments
Closed

Wheels are not being built #205

tomwhite opened this issue Jul 19, 2021 · 16 comments

Comments

@tomwhite
Copy link
Collaborator

The latest version on PyPi is 0.30.4, even though 0.30.8 has been released. The wheel build failed but the logs have expired so unfortunately it's not possible to see what went wrong.

It might be worth building wheels on every main build (in addition to tags), and perhaps on a schedule too.

@tomwhite
Copy link
Collaborator Author

I'm not sure if this is the same problem, but even the 0.30.4 wheel (cyvcf2-0.30.4-cp38-cp38-manylinux2014_x86_64.whl) can't read remote VCF files on a GH Actions linux machine:

Python 3.8.11 (default, Jul  5 2021, 19:22:52) 
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from cyvcf2 import VCF
>>> VCF('test.vcf.gz')
<cyvcf2.cyvcf2.VCF object at 0x7fbfcb7f84a0>
>>> VCF('https://github.com/brentp/cyvcf2/raw/master/cyvcf2/tests/test.vcf.gz')
[E::hts_open_format] Failed to open file "https://github.com/brentp/cyvcf2/raw/master/cyvcf2/tests/test.vcf.gz" : Input/output error
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "cyvcf2/cyvcf2.pyx", line 257, in cyvcf2.cyvcf2.VCF.__init__
  File "cyvcf2/cyvcf2.pyx", line 189, in cyvcf2.cyvcf2.HTSFile._open_htsfile
OSError: Error opening https://github.com/brentp/cyvcf2/raw/master/cyvcf2/tests/test.vcf.gz

If the file is local it works OK.

Environment:

Current runner version: '2.278.0'
Operating System
  Ubuntu
  20.04.2
  LTS
Virtual Environment
  Environment: ubuntu-20.04
  Version: 20210718.1
  Included Software: https://github.com/actions/virtual-environments/blob/ubuntu20/20210718.1/images/linux/Ubuntu2004-README.md
  Image Release: https://github.com/actions/virtual-environments/releases/tag/ubuntu20%2F20210718.1

I used https://github.com/mxschmitt/action-tmate to get a shell on the GH actions container.

@tomwhite
Copy link
Collaborator Author

It looks like #174 may be related.

@brentp
Copy link
Owner

brentp commented Jul 19, 2021

I think we'd need --enable-libcurl in the configure ares in the build.yml

@brentp
Copy link
Owner

brentp commented Jul 19, 2021

but that's already in the wheels.yml !?

@tomwhite
Copy link
Collaborator Author

Could possibly be a SSL library issue, along the lines of #175 (comment)?

Hopefully when I manage to SSH into a failing build I'll be able to get more info.

@brentp
Copy link
Owner

brentp commented Jul 19, 2021

Let me know if you need anything from me to be able to get in. I added you as collaborator to the repo.

@tomwhite
Copy link
Collaborator Author

Thanks @brentp!

@brentp
Copy link
Owner

brentp commented Jul 19, 2021

Thank you!

@tomwhite
Copy link
Collaborator Author

The mac wheel build contains the line (from trying to build htslib):

configure: error: cannot find required auxiliary files: config.guess config.sub

So configure isn't running properly, and the build fails. The problem seems to be autoconf 2.71 - downgrading to 2.69 (following the instructions in https://gist.github.com/oriolgual/2f881fa3a151dd5f643f755ddcf2a0bc from https://stackoverflow.com/questions/67442905/asdf-erlang-fails-to-compile-on-macos), made configure work again. There may be better ways of downgrading autoconf though.

The linux build has the same error, even though it seems to have autoconf 2.69 already, which is odd.

@brentp
Copy link
Owner

brentp commented Jul 19, 2021

@brentp
Copy link
Owner

brentp commented Jul 20, 2021

In ubuntu:18.04, libssl is here: /usr/lib/x86_64-linux-gnu/
and there is no directory or path to: /usr/lib64/openssl1 unless that is being installed by something in github actions.

@brentp
Copy link
Owner

brentp commented Jul 20, 2021

and headers are in: /usr/include/openssl/
not in /usr/include/openssl11

@tomwhite
Copy link
Collaborator Author

I'm not sure if these paths are correct or not, @horta might know.

The fix in #211 gets back to a point where the wheel build works again (I think).

@brentp
Copy link
Owner

brentp commented Jul 20, 2021

seems it's working now, eh? https://github.com/brentp/cyvcf2/actions/runs/1048452332
if you agree, I'll tag a new release to verify.

@tomwhite
Copy link
Collaborator Author

Yes, please go ahead and tag.

@brentp
Copy link
Owner

brentp commented Jul 20, 2021

0.30.9 now on pypi: https://pypi.org/project/cyvcf2/

thanks very much for fixing.

@brentp brentp closed this as completed Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants