You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The loop in https://github.com/brendangregg/FlameGraph/blob/master/flamegraph.pl#L1077 which iterates over <g> elements, does not check if they have currently the .hide class. These elements still have their x and width values from before zoom, and seem to be collected in the matches hashmap, and counted towards count.
What I expected:
The "Matched: x%" text should mean that the frames that (match the CTRL+F query) AND (are currently visible) consititute x% of the visible region.
What happens instead:
The "Matched: x%" text seams to mean that the frames that (match the CTRL+F query) consititute x% of the visible region.
Why does it matter:
This results in the Matched: 69.5% instead of Matched: 55.8% text in my case, but in general the differece can be arbitrarily huge.
This is a problem to me, because I have function outer() which calls inner() and I wanted to know relation of inner()/outer() for each callstack separately - so I've zoomed to each call of outer() one by one and noted down the ratio, and was puzzled that the ratio is always larger than the average ratio (which I computed by zooming out and searching for outer() and inner() separately).
The text was updated successfully, but these errors were encountered:
The loop in https://github.com/brendangregg/FlameGraph/blob/master/flamegraph.pl#L1077 which iterates over
<g>
elements, does not check if they have currently the.hide
class. These elements still have theirx
andwidth
values from before zoom, and seem to be collected in thematches
hashmap, and counted towardscount
.What I expected:
The "Matched: x%" text should mean that the frames that (match the CTRL+F query) AND (are currently visible) consititute x% of the visible region.
What happens instead:
The "Matched: x%" text seams to mean that the frames that (match the CTRL+F query) consititute x% of the visible region.
Why does it matter:
This results in the
Matched: 69.5%
instead ofMatched: 55.8%
text in my case, but in general the differece can be arbitrarily huge.This is a problem to me, because I have function
outer()
which callsinner()
and I wanted to know relation ofinner()/outer()
for each callstack separately - so I've zoomed to each call ofouter()
one by one and noted down the ratio, and was puzzled that the ratio is always larger than the average ratio (which I computed by zooming out and searching forouter()
andinner()
separately).The text was updated successfully, but these errors were encountered: