You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 31, 2020. It is now read-only.
From @bridiver comment #226 (comment)
we should handle the case where all 3 are blank (first node added) - we really have no use or need for the base order in the client and I think we should encapsulate all the logic here so the client doesn't have to know or care about how the order works, so I think we should store it in the lib and use it for this case
Add call setBaseBookmarksOrder(deviceId, platform) which client would call after eash start.
Then call getBookmarkOrder(prevOrder, nextOrder, parentOrder) will always succeed even for the case when all thre arguments are empty - this means we want to get order for very root bookmark object (folder) and return baseBookmarksOrder+"1" .
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
From @bridiver comment #226 (comment)
we should handle the case where all 3 are blank (first node added) - we really have no use or need for the base order in the client and I think we should encapsulate all the logic here so the client doesn't have to know or care about how the order works, so I think we should store it in the lib and use it for this case
Add call setBaseBookmarksOrder(deviceId, platform) which client would call after eash start.
Then call getBookmarkOrder(prevOrder, nextOrder, parentOrder) will always succeed even for the case when all thre arguments are empty - this means we want to get order for very root bookmark object (folder) and return
baseBookmarksOrder+"1"
.The text was updated successfully, but these errors were encountered: