Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overly aggressive replacement of person/people with profile(s). #42287

Open
mkarolin opened this issue Nov 13, 2024 · 0 comments · May be fixed by brave/brave-core#26540
Open

Fix overly aggressive replacement of person/people with profile(s). #42287

mkarolin opened this issue Nov 13, 2024 · 0 comments · May be fixed by brave/brave-core#26540
Assignees
@mkarolin
Labels
dev-concern l10n OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude

Comments

@mkarolin
Copy link
Contributor

We replace person/people in Chromium string with profile(s) to remove the signed-in user terminology in Chromium. However, this replacement affects some strings that aren't relevant for this purpose. For example:
Ask in person becomes Ask in profile, etc.

We should fix the string that shouldn't have the replacements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
dev-concern l10n OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes aggressive replacements of person/people with profile(s). brave/brave-core
1 participant
@mkarolin