Codehealth: Run performance-move-const-arg check on the codebase
#42230
Comments
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Nov 12, 2024
This check has detected a few places where the use of `std::move` has been completely misleading. In one of them we are potentially incurring in a bug, as we are moving a shared callback that is being used in a loop. https://clang.llvm.org/extra/clang-tidy/checks/performance/move-const-arg.html Resolves brave/brave-browser#42230
24 tasks
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Nov 12, 2024
This check has detected a few places where the use of `std::move` has been completely misleading. In one of them we are potentially incurring in a bug, as we are moving a shared callback that is being used in a loop. https://clang.llvm.org/extra/clang-tidy/checks/performance/move-const-arg.html Resolves brave/brave-browser#42230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
For more details on this check:
https://clang.llvm.org/extra/clang-tidy/checks/performance/move-const-arg.html
The text was updated successfully, but these errors were encountered: