Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow up to #39552] Title for Edit button needs to be updated to Done when editing custom SE #41210

Open
2 of 5 tasks
hffvld opened this issue Sep 23, 2024 · 0 comments
Open
2 of 5 tasks
Labels
bug OS/iOS Fixes related to iOS browser functionality QA/Yes

Comments

@hffvld
Copy link
Contributor

hffvld commented Sep 23, 2024

Description

Follow-up to #39552.

Steps to reproduce

  1. Launch Brave
  2. Hamburger menu > Settings
  3. Search Engines > Add Custom Search Engine
  4. In URL type https://youtube.com/search?q=%s and in Title type YT > Done
  5. Slide the newly created SE to the left > Tap Edit
  6. Update the Title > Observe

Actual result

If editing custom SE (any of URL or Title), the button title (top right corner) says Edit instead of Done.


1 2
1 2

Expected result

The title for Edit button needs to be updated to Done when editing custom SE.

Reproduces how often

Easily reproduced

Brave version

Brave build: 1.70 (117)
BraveCore: 1.70.117 (129.0.6668.59)

Device/iOS version

iPad Mni (6th gen) / iPadOS 18

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@hffvld hffvld added bug QA/Yes OS/iOS Fixes related to iOS browser functionality labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OS/iOS Fixes related to iOS browser functionality QA/Yes
Projects
None yet
Development

No branches or pull requests

1 participant