Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer a search widget similar to Firefox on Android #41205

Closed
3 of 6 tasks
mherrmann opened this issue Sep 23, 2024 · 2 comments · Fixed by brave/brave-core#25696
Closed
3 of 6 tasks

Offer a search widget similar to Firefox on Android #41205

mherrmann opened this issue Sep 23, 2024 · 2 comments · Fixed by brave/brave-core#25696
Assignees
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude

Comments

@mherrmann
Copy link

Description

On Android on first launch, Firefox offers to set up a search widget:

Screenshot_20240923-140049

It looks like this on the home screen:

Screenshot_20240923-140157

We should have something similar. It is a great way to increase retention.

Steps to reproduce

Launch Brave on Android for the first time.

Actual result

Brave does not offer to install a search widget.

Expected result

Brave should offer to install a search widget.

Reproduces how often

Easily reproduced

Brave version

All

Device

  • Brand/model: Google Pixel 7
  • Android version: 14

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@kjozwiak
Copy link
Member

kjozwiak commented Nov 7, 2024

The above requires 1.73.86 or higher for 1.73.x verification 👍 @Uni-verse @hffvld can use the STR/Template from brave/brave-core#25696 (comment) to verify the above.

@hffvld
Copy link
Contributor

hffvld commented Nov 7, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 15 AP41.240925.009 release-keys
Brave build: 1.73.86 
Chromium: 131.0.6778.39 (Official Build) (64-bit) 

Filed follow-up issue #42170

Test case 1

STEPS:

  1. Fresh install Brave
  2. Connect the device to the Terminal and run ADB command adb shell "echo '--enable-features=BraveDayZeroExperiment:variant/a' > /data/local/tmp/brave-test-day-zero-expt"
  3. Launch Brave > Verify

ACTUAL RESULTS:

  • Verified that the Set Brave as your default browser app? system dialog shows up on the first page of onboarding:
    • Verified that selecting Brave as the default worked without issues.
    • Verified that selecting browsers other than Brave as the default worked without issues.
    • Verified that selecting Cancel worked without issues and left the current browser as the default.
  • Verified that the Add the search widget onboarding modal is being displayed right after the Set Brave as your default browser app? system dialog:
    • Verified that tapping on Now now dismisses the modal without initiating the Add the search widget modal.
    • Verified that tapping on Add to home screen initiates the widget modal:
      • Verified that tapping on Cancel closes the modal and you can continue onboarding via the diagnostic/P3A modal.
      • Verified that tapping on Add to home screen adds the Brave widget to the Home screen without any issues.
      • Verified that touching/holding lets you drag/drop the Brave widget to the Home screen without any issues.
  • Verified that the Diagnostic & P3A modals work as before (this hasn't been modified/touched).

1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
2024-11-07_13-59-06.mp4
Test case 2

STEPS:

  1. Fresh install Brave
  2. Connect the device to the Terminal and run ADB command adb shell "echo '--enable-features=BraveDayZeroExperiment:variant/b' > /data/local/tmp/brave-test-day-zero-expt"
  3. Launch Brave > Verify

ACTUAL RESULTS:

  • Verified that the regular/normal onboarding flow shown and works as expected.
  • Verified that Set default browser system dialog or Add search widget onboarding are not shown.

2024-11-07_12-44-34.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants