Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow up to #36036] Filter search not returning correct results #41168

Closed
2 of 5 tasks
Uni-verse opened this issue Sep 20, 2024 · 2 comments · Fixed by brave/brave-core#25675
Closed
2 of 5 tasks

[Follow up to #36036] Filter search not returning correct results #41168

Uni-verse opened this issue Sep 20, 2024 · 2 comments · Fixed by brave/brave-core#25675
Assignees
Labels
bug feature/user-interface All UI related OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - iPhone QA/Yes release-notes/exclude

Comments

@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 20, 2024

Description

Seems like some issues with searching the filters. Likely that captial letters can be searched.

Steps to reproduce

  1. New install
  2. Open Settings -> Brave Shields & Privacy -> Content Filtering
  3. Use the search bar at the top to search for some lists, example: youtube
  4. Observe results

Actual result

Case issues in search?? Not returning all lists
IMG_7369 IMG_7370

Expected result

Should return correct results

Reproduces how often

Easily reproduced

Brave version

1.70.117

Device/iOS version

iPhone 12 / iOS 18 & 17

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@LaurenWags
Copy link
Member

Requires 1.70.122 or higher for verification 👍🏻

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 2, 2024
@hffvld
Copy link
Contributor

hffvld commented Oct 2, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.7
Brave build: 1.70 (123)
BraveCore: 1.70.123 (129.0.6668.89)

STEPS:

  1. Follow the STR/TP from [Follow up to #36036] Filter search not returning correct results #41168 (comment) and fix(privacy): Filter search case sensitivity on iOS brave-core#25675 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the Search in Content Filtering works and shows correct results

1 2 3
1 2 3

@hffvld hffvld added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/user-interface All UI related OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants