Browser crash when trying to close tab with sidebar open

[srirambv]

Description

IMPORTANT: Your crash has already been automatically reported to our crash system. Please file this bug only if you can provide more information about it.

Brave Version: 1.70.115 Chromium: 129.0.6668.59
Operating System: Windows NT 10.0.22631

URL (if applicable) where crash occurred:

Can you reproduce this crash?
Yes

What steps will reproduce this crash? (If it's not reproducible, what were you doing just before the crash?)

1. Launch browser with Leo pointing to staging
2. Connect to staging account and load Leo credentials
3. Open a new tab and load Leo in sidebar
4. Navigate back and forth between two tabs where Leo is opened in both
5. Close one of the tab
6. Browser crashes

DO NOT CHANGE BELOW THIS LINE
Crash ID: crash/ead61900-9ce4-970c-0000-000000000000
Crash ID: crash/e7d61900-9ce4-970c-0000-000000000000

cc: @brave/qa-team @iefremov @rebron

[mkarolin]

cc: @simonhong @petemill

The crash stack is not symbolized and I found it a bit difficult to reproduce. The one way I was able to reproduce (assuming it's the same crash) was under a debugger by:

1. Start browser
2. In tab A open Chat UI
3. Open a new tab (B) and open Reading list
4. Open a new tab (C) (Reading list should be showin)
5. Close tab B
6. Activate tab A
7. Close the browser
8. Crash with ACCESS_VIOLATION:

ntdll.dll!00007ffddcbf2650()
base.dll!base::internal::LockImpl::Try() Line 103
	at C:\bb2\brave-browser\src\base\synchronization\lock_impl.h(103)
base.dll!base::internal::LockImpl::Lock() Line 94
	at C:\bb2\brave-browser\src\base\synchronization\lock_impl.h(94)
base.dll!base::Lock::Acquire(base::subtle::LockTracking tracking) Line 52
	at C:\bb2\brave-browser\src\base\synchronization\lock.cc(52)
base.dll!base::internal::BasicAutoLock<base::Lock>::BasicAutoLock(base::Lock & lock, base::subtle::LockTracking tracking) Line 147
	at C:\bb2\brave-browser\src\base\synchronization\lock_impl.h(147)
base.dll!base::SequenceCheckerImpl::CalledOnValidSequence(std::__Cr::unique_ptr<base::debug::StackTrace,std::__Cr::default_delete<base::debug::StackTrace>> * out_bound_at) Line 89
	at C:\bb2\brave-browser\src\base\sequence_checker_impl.cc(89)
base.dll!base::ScopedValidateSequenceChecker::ScopedValidateSequenceChecker(const base::SequenceCheckerImpl & checker) Line 21
	at C:\bb2\brave-browser\src\base\sequence_checker.cc(21)
components_prefs.dll!PrefService::GetValue(std::__Cr::basic_string_view<char,std::__Cr::char_traits<char>> path) Line 348
	at C:\bb2\brave-browser\src\components\prefs\pref_service.cc(348)
components_prefs.dll!PrefService::GetTime(std::__Cr::basic_string_view<char,std::__Cr::char_traits<char>> path) Line 519
	at C:\bb2\brave-browser\src\components\prefs\pref_service.cc(519)
chrome.dll!ai_chat::HasUserOptedIn(PrefService * prefs) Line 71
	at C:\bb2\brave-browser\src\brave\components\ai_chat\core\browser\utils.cc(71)
chrome.dll!ai_chat::ConversationDriver::HasUserOptedIn() Line 583
	at C:\bb2\brave-browser\src\brave\components\ai_chat\core\browser\conversation_driver.cc(583)
chrome.dll!ai_chat::ConversationDriver::ShouldFetchSearchQuerySummary() Line 368
	at C:\bb2\brave-browser\src\brave\components\ai_chat\core\browser\conversation_driver.cc(368)
chrome.dll!ai_chat::ConversationDriver::MaybeFetchOrClearSearchQuerySummary(base::OnceCallback<void (const std::__Cr::optional<std::__Cr::vector<ai_chat::SearchQuerySummary,std::__Cr::allocator<ai_chat::SearchQuerySummary>>> &)> callback) Line 379
	at C:\bb2\brave-browser\src\brave\components\ai_chat\core\browser\conversation_driver.cc(379)
chrome.dll!ai_chat::ConversationDriver::OnConversationActiveChanged(bool is_conversation_active) Line 351
	at C:\bb2\brave-browser\src\brave\components\ai_chat\core\browser\conversation_driver.cc(351)
chrome.dll!ai_chat::AIChatUIPageHandler::OnVisibilityChanged(content::Visibility visibility) Line 470
	at C:\bb2\brave-browser\src\brave\browser\ui\webui\ai_chat\ai_chat_ui_page_handler.cc(470)
content.dll!content::WebContentsImpl::WebContentsObserverList::NotifyObservers<void (content::WebContentsObserver::*)(content::Visibility),content::Visibility &>(void(content::WebContentsObserver::*)(content::Visibility) func, content::Visibility & args) Line 1686
	at C:\bb2\brave-browser\src\content\browser\web_contents\web_contents_impl.h(1686)
content.dll!content::WebContentsImpl::SetVisibilityAndNotifyObservers(content::Visibility visibility) Line 6157
	at C:\bb2\brave-browser\src\content\browser\web_contents\web_contents_impl.cc(6157)
content.dll!content::WebContentsImpl::UpdateVisibilityAndNotifyPageAndView(content::Visibility new_visibility, bool is_activity) Line 4403
	at C:\bb2\brave-browser\src\content\browser\web_contents\web_contents_impl.cc(4403)
content.dll!content::WebContentsImpl::UpdateWebContentsVisibility(content::Visibility visibility) Line 10534
	at C:\bb2\brave-browser\src\content\browser\web_contents\web_contents_impl.cc(10534)
content.dll!content::WebContentsViewAura::UpdateWebContentsVisibility() Line 975
	at C:\bb2\brave-browser\src\content\browser\web_contents\web_contents_view_aura.cc(975)
content.dll!content::WebContentsViewAura::OnWindowOcclusionChanged(aura::Window::OcclusionState old_occlusion_state, aura::Window::OcclusionState new_occlusion_state) Line 1305
	at C:\bb2\brave-browser\src\content\browser\web_contents\web_contents_view_aura.cc(1305)
ui_aura.dll!aura::Window::SetOcclusionInfo(aura::Window::OcclusionState occlusion_state, const SkRegion & occluded_region) Line 1104
	at C:\bb2\brave-browser\src\ui\aura\window.cc(1104)
ui_aura.dll!aura::DefaultWindowOcclusionChangeBuilder::~DefaultWindowOcclusionChangeBuilder() Line 30
	at C:\bb2\brave-browser\src\ui\aura\window_occlusion_change_builder.cc(30)
ui_aura.dll!aura::DefaultWindowOcclusionChangeBuilder::~DefaultWindowOcclusionChangeBuilder() Line 26
	at C:\bb2\brave-browser\src\ui\aura\window_occlusion_change_builder.cc(26)
ui_aura.dll!std::__Cr::default_delete<aura::WindowOcclusionChangeBuilder>::operator()(aura::WindowOcclusionChangeBuilder * __ptr) Line 69
	at C:\bb2\brave-browser\src\third_party\libc++\src\include\__memory\unique_ptr.h(69)
ui_aura.dll!std::__Cr::unique_ptr<aura::WindowOcclusionChangeBuilder,std::__Cr::default_delete<aura::WindowOcclusionChangeBuilder>>::reset(aura::WindowOcclusionChangeBuilder * __p) Line 281
	at C:\bb2\brave-browser\src\third_party\libc++\src\include\__memory\unique_ptr.h(281)
ui_aura.dll!std::__Cr::unique_ptr<aura::WindowOcclusionChangeBuilder,std::__Cr::default_delete<aura::WindowOcclusionChangeBuilder>>::~unique_ptr() Line 249
	at C:\bb2\brave-browser\src\third_party\libc++\src\include\__memory\unique_ptr.h(249)
ui_aura.dll!aura::WindowOcclusionTracker::MaybeComputeOcclusion() Line 330
	at C:\bb2\brave-browser\src\ui\aura\window_occlusion_tracker.cc(330)
ui_aura.dll!aura::WindowOcclusionTracker::Unpause() Line 814
	at C:\bb2\brave-browser\src\ui\aura\window_occlusion_tracker.cc(814)
ui_aura.dll!aura::WindowOcclusionTracker::ScopedPause::~ScopedPause() Line 200
	at C:\bb2\brave-browser\src\ui\aura\window_occlusion_tracker.cc(200)
ui_aura.dll!aura::Window::SetVisibleInternal(bool visible) Line 1090
	at C:\bb2\brave-browser\src\ui\aura\window.cc(1090)
ui_aura.dll!aura::Window::Hide() Line 372
	at C:\bb2\brave-browser\src\ui\aura\window.cc(372)
ui_views.dll!views::DesktopWindowTreeHostWin::Close() Line 248
	at C:\bb2\brave-browser\src\ui\views\widget\desktop_aura\desktop_window_tree_host_win.cc(248)
ui_views.dll!views::DesktopNativeWidgetAura::Close() Line 913
	at C:\bb2\brave-browser\src\ui\views\widget\desktop_aura\desktop_native_widget_aura.cc(913)
ui_views.dll!views::Widget::CloseWithReason(views::Widget::ClosedReason closed_reason) Line 838
	at C:\bb2\brave-browser\src\ui\views\widget\widget.cc(838)
ui_views.dll!views::Widget::Close() Line 842
	at C:\bb2\brave-browser\src\ui\views\widget\widget.cc(842)
chrome.dll!BrowserView::Close() Line 1443
	at C:\bb2\brave-browser\src\chrome\browser\ui\views\frame\browser_view.cc(1443)
chrome.dll!Browser::TabStripEmpty() Line 1562
	at C:\bb2\brave-browser\src\chrome\browser\ui\browser.cc(1562)
chrome.dll!BraveBrowser::TabStripEmpty() Line 132
	at C:\bb2\brave-browser\src\brave\browser\ui\brave_browser.cc(132)
chrome.dll!TabStripModel::SendDetachWebContentsNotifications(TabStripModel::DetachNotifications * notifications) Line 483
	at C:\bb2\brave-browser\src\chrome\browser\ui\tabs\tab_strip_model.cc(483)
chrome.dll!TabStripModel::CloseTabs(base::span<content::WebContents *const,18446744073709551615,content::WebContents *const *> items, unsigned int close_types) Line 2085
	at C:\bb2\brave-browser\src\chrome\browser\ui\tabs\tab_strip_model.cc(2085)
chrome.dll!TabStripModel::CloseAllTabs() Line 676
	at C:\bb2\brave-browser\src\chrome\browser\ui\tabs\tab_strip_model.cc(676)
chrome.dll!Browser::OnWindowClosing() Line 1241
	at C:\bb2\brave-browser\src\chrome\browser\ui\browser.cc(1241)
chrome.dll!UnloadController::ProcessPendingTabs(bool skip_beforeunload) Line 356
	at C:\bb2\brave-browser\src\chrome\browser\ui\unload_controller.cc(356)
chrome.dll!UnloadController::ClearUnloadState(content::WebContents * web_contents, bool process_now) Line 442
	at C:\bb2\brave-browser\src\chrome\browser\ui\unload_controller.cc(442)
chrome.dll!UnloadController::CanCloseContents(content::WebContents * contents) Line 54
	at C:\bb2\brave-browser\src\chrome\browser\ui\unload_controller.cc(54)
chrome.dll!Browser::CloseContents(content::WebContents * source) Line 2012
	at C:\bb2\brave-browser\src\chrome\browser\ui\browser.cc(2012)
content.dll!content::WebContentsImpl::Close() Line 8536
	at C:\bb2\brave-browser\src\content\browser\web_contents\web_contents_impl.cc(8536)
content.dll!content::RenderFrameHostImpl::ClosePageIgnoringUnloadEvents(content::RenderFrameHostImpl::ClosePageSource source) Line 6554
	at C:\bb2\brave-browser\src\content\browser\renderer_host\render_frame_host_impl.cc(6554)

However, after brave/brave-core#24921 was merged I can't repro with those steps any more.
Don't think it matters, but I was testing with brave/brave-core#25679 changes in the tree.

[GeetaSarvadnya]

Reproduced the issue on Windows 10 x64 - 1.70.117 Chromium: 129.0.6668.59

Uploaded Crash Report ID: | a4351900-162b-a10c-0000-000000000000
Upload Time: | Tuesday, September 24, 2024 at 2:23:07 PM