-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group policy/settings: configuration for --sync-url= argument #20431
Comments
I'd very much like to see this implemented too. Even exposing the setting in a config file like
This might be my own shortcoming, but the linked documentation at support.brave.com only mentions Windows. If this applies to Linux and Mac as well, instructions (for users outside a managed corporate IT environment) could be useful. |
Another aspect of missing a persistent setting is that it's easy to commit changes to the public sync server by accident. I've tested & verified the following:
Apparently the sync chain gets implicitly created (either by Brave or the sync service). IMO more expected behaviour would have been for Brave to issue an error message if the sync chain that had earlier been set up doesn't exist on the server. |
This is requested since long time. Hope this gets some new traction. I cannot believe that a UI switch in both desktop and mobile versions is that much of a deal. Already offered my support and finding my way through the Code despite being a complete noob when I at least receive a clue where to start 😞 |
What should be done is that a setting should be added in the brave sync menu to change the URL of the sync server. This will be a user friendly way to changing the server and will allow you to use your self hosted sync server on desktop and mobile. |
Why has this basic feature request languished for over a year? Self-hosting a bravesync server is only practical/useful if we can set the self-hosted bravesync sever location within brave browser settings! Thank you to the amazing team at Brave, but this right here is a curious omission. Please advise. |
Are there any plans to give this more priority? Or is there some sort of Roadmap for Brave? |
They f8cking shadow deleted the issue. Edit: They as in somebody, I have no clue who might have done that and for what reason, may have been accidental. |
@NicholasFlamy (and others) for full transparency, I'm not sure who deleted that issue. I'm trying to find out now - I've asked internally and so far haven't found anyone with privs that has done this. I'll dig in more and find out For now, you are welcome to recreate the issue. I don't have the original issue content - was this just asking to make the URL configurable in app? UPDATE: I opened a ticket with GitHub support to find out what happened |
I pulled up the latest Google Webcache of it and posted a link to the Webcache in the discussion I made: I might make a new issue but I'll hold off because the issue being deleted is super strange. |
@NicholasFlamy got a response from GitHub - seems the person who created the original issue set their account as private and that is why it's not showing. We definitely keep posts up - although sometimes we will remove posts in an issue if they cross the line (disrespectful, etc). Please create a new issue describing what you were wanting. Here's the official response from GitHub support: |
Wow, that's something I've never seen before. Okay, I'll get on it. |
#37448 made this for now. |
This really, really, really shouldn't be a two-year delayed feature. For an open source project the fact I can't use a basic feature on my phone without using their servers is really annoying |
It seems extremely suspicious that this simple issue has not been resolved. There are so many ways to fix it, i.e. UI option, This would certainly qualify as a priority issue for a browser that emphasizes privacy to the extent Brave does. Customers switching to Brave absolutely want this functionality as we are increasingly turning our backs on corporate-owned clouds in general. This feature would be significantly more popular if officially supported. Not actioning this request is clearly deliberate, but with no stated reason perhaps we should question why Brave are resisting. There is a dizzying amount of information in sync payloads and I highly suspect these may not be as private and secure as Brave claim. Is this omission Brave's warrant canary? Is Brave being compelled to retain a role in the flow of sync data by outside influences? |
I couldn't resist - There is exactly one mention of I have a domain name that is a few characters less than that in length. Using a hex editor, I overwrote the brave URL with mine and padded the dead space with null characters. Amazingly this works according to I'm going down with the Win7 ship, so I'm on 1.47.186. Maybe this works in newer versions too? If it does, a patcher would only be a few lines of Python, a scheduled task and a line in the |
thats hilarious, but i rather keep using firefox until they implement it than adding a weekly task of updating and patching to my schedule :D if it really is that easy, its also really suspicious why they would not add this.. |
cool, someone make a script to do this with the APK or something lol |
For real! I just started looking for alternative browser (using Edge for work, but Firefox at home with selfhosted sync) and my only requirement is self-hostable sync server, preferably to work cross platform (Windows + Linux + Android). Brave would be the IDEAL choice if it had self-hostable browser, but it looks quite shady why they didn't implement one of the very basic features in a product marketed as a privacy focused, user data respecting browser! |
So on desktop I have been using the command line argument. On mobile I have been using the developer options QA Preferences menu and the command line string option. |
This is amazing! So I assume its possible to get a browser that do any outgoing connections I didn't tell it to make? I mean, I want to setup my sync server, but want to make sure that the browser is not sending any request except to my server, and ofc the web pages I only open, is that possible ..? I may setup a test few hours later, if that achievable then I'm definitely switching to brave! |
So if you want to be more secure about it you could firewall your setup and block the default brave sync server, on case your browser crashes and relaunches and therefore wasn't launched from the shortcut on desktop. But yeah. Edit: personally I don't firewall it at the moment. I just configured the sync server on both desktop and mobile. Also, I would recommend against storing passwords in Brave simply because sync broke on my Android phone (through strangely not my Android Tablet) and is an issue for some others. Also, a dedicated password manager such as Bitwarden (I self-host VaultWarden) is usually considered better. |
Or it should just have a proper setting rather than using a command-line arg, which avoids this risk |
OK folks - this is merged 😄 Unfortunately, I couldn't find a way to do Android group policy. I do believe it's possible - but I don't know at the moment though. If someone has more information, please do share it. I'll work with @jagadeshjai on brave/brave-core#25484 next |
I appreciate the work! If configuration through the UI is the solution for Android (and I assume same for iOS) then that's alright. |
Verification
Installed 1.72.85 Case 1: Using regedit.exe
Case 2: Adding using a .reg file
|
@MadhaviSeelam Great, thanks! Can you confirm whether there is also work going on to enable it on iOS? |
They're working on a GUI option that will handle mobile as well (since afaik mobile doesn't have policies): brave/brave-core#25484 |
Unfortunately, I'm not sure how to do group policy on iOS and Android. I believe it's possible, I just don't know how @NicholasFlamy thanks for linking the custom URL one. That will solve for Desktop. We'll need to do a similar pull request for Android and iOS to enable changing sync URL. |
Verification
|
Verified with
Verified modified test plan from brave/brave-core#25498 (comment) for Linux. Notes - I created each directory under Confirmed that once created, the file displays under brave://policy: Confirmed that once the |
Test plan
See brave/brave-core#25498
Description
There should be a group policy or UI option for Brave to provide the
--sync-url=
option without needing to explicitly add a command-line argument.One issue is that adding command line arguments varies a lot by platform:
~/.config/chrome-flags.conf
file (where each line of the file is treated as a command line argument appended whenever the browser is launched).A group policy config option would be ideal, because deploying that kind of policy is well defined for each platform. Adding this also makes self-hosting a sync server much easier.
Alternatively, a UI option to customize the sync server URL would be nice as well. As long as the setting persists without needing to add a command-line flag.
Steps to Reproduce
N/A, see description.
Actual result:
The
--sync-url=
option is difficult to configure consistently across platforms. Self-hosting a sync server is very difficult without a way to consistently customize the sync URL.Expected result:
The
--sync-url=
option should be configurable across platforms without having to resort to manipulating command line arguments, to enable self-hosting a sync server.Reproduces how often:
Always?
Desktop Brave version:
Version/Channel Information:
All channels at the moment. Nothing provides more than the
--sync-url=
flag.Other Additional Information:
N/A
N/A
N/A
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: