Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace uses of log.Fatal with log.Panic #2564

Open
Sneagan opened this issue Jun 13, 2024 · 0 comments
Open

Replace uses of log.Fatal with log.Panic #2564

Sneagan opened this issue Jun 13, 2024 · 0 comments

Comments

@Sneagan
Copy link
Contributor

Sneagan commented Jun 13, 2024

          I don't like this `Fatal` here at all (because nothing deferred will happen). But there are already quite a few others.

Technically, this is incorrect. The opened file won't be properly closed. If you want to terminate without too much hassle in this closure, better use log.Panic instead.

Originally posted by @pavelbrm in #2544 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant