Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change label issue colors to make sure they look readable in the website #59

Open
Remi-Gau opened this issue Nov 17, 2023 · 5 comments
Open

Comments

@Remi-Gau
Copy link
Member

Remi-Gau commented Nov 17, 2023

see example below

image

@crnolan
Copy link
Collaborator

crnolan commented Nov 18, 2023

Interesting, I didn't realise there was some kind of transformation going on with the github labels and text colours to the website labels. I added the location ones that just look solid yellow there. Will have to look into where the transform is happening.

@Remi-Gau
Copy link
Member Author

I think that the label colors are not changed but I may be wrong.

Because the doc for all lacks a lot of breadcrumb:

this is the mini package that is used to convert project issues to pages for the website:

https://github.com/brainhackorg/braintransform/tree/main

The main module of interest: https://github.com/brainhackorg/braintransform/blob/main/braintransform/issues_to_pages.py

@crnolan
Copy link
Collaborator

crnolan commented Nov 21, 2023

Thanks @Remi-Gau, I'll need to dig further; the label background is consistent, but the text colour changes even within the same label at different locations on the page (e.g. the location labels at the top have yellow or white text, but black text in the project itself).

@Remi-Gau
Copy link
Member Author

oh indeed: ok then that may be some html / CSS magic in this case because nothing in our code that sets the font color (that I am aware of)

@Remi-Gau
Copy link
Member Author

maybe easiest to just change the label color in here: https://github.com/brainhackorg/global2023/labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants