Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removal of unused cmake and vcpkg stuff, and adding bold red to some error messages #867

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

braindigitalis
Copy link
Contributor

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

@braindigitalis braindigitalis self-assigned this Sep 20, 2023
@braindigitalis braindigitalis marked this pull request as ready for review September 20, 2023 08:46
@braindigitalis braindigitalis changed the base branch from master to dev September 20, 2023 08:47
@raxyte raxyte added the build Issue or Pull Request related to the build process label Sep 21, 2023
@braindigitalis braindigitalis merged commit 4a17d83 into dev Sep 22, 2023
70 checks passed
@Jaskowicz1 Jaskowicz1 deleted the vcpkg_tidyup branch April 5, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issue or Pull Request related to the build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants