Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove ninja for all but windows, for us it is slower than make -j2 #857

Merged
merged 6 commits into from
Sep 16, 2023

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Sep 15, 2023

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

@netlify
Copy link

netlify bot commented Sep 15, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit f0daf75
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6504c031fc3f0b0008730765
😎 Deploy Preview https://deploy-preview-857--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jaskowicz1
Copy link
Contributor

I like the branch name 👍

@braindigitalis
Copy link
Contributor Author

I'm done tweaking this now, ready for review.
2x speed improvement in Linux and mac builds, 25% speed increases in windows. moved voice connection unit tests to extended as they are no longer reliable on GitHub runners.

@braindigitalis braindigitalis merged commit 4f18eb8 into dev Sep 16, 2023
53 checks passed
@braindigitalis braindigitalis deleted the kill_the_ninja branch September 16, 2023 15:49
Mishura4 pushed a commit to Mishura4/DPP-PRs that referenced this pull request Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants