Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: cleaned up windows_wsl.md #851

Merged
merged 3 commits into from
Sep 10, 2023
Merged

docs: cleaned up windows_wsl.md #851

merged 3 commits into from
Sep 10, 2023

Conversation

Jaskowicz1
Copy link
Contributor

This PR makes windows_wsl.md more explicit to the fact that it uses Ubuntu WSL2. This PR also merges the changes from #820.

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

Co-authored-by: Jakub 'Eremiell' Marek <[email protected]>
@netlify
Copy link

netlify bot commented Sep 9, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 459f8c3
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/64fdb93b16c879000810e2e9
😎 Deploy Preview https://deploy-preview-851--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Mishura4 Mishura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the new line at the end of the file!

@Jaskowicz1
Copy link
Contributor Author

Don't forget the new line at the end of the file!

That's been fixed and pushed up!

@Commandserver Commandserver merged commit 3d01c4d into brainboxdotcc:dev Sep 10, 2023
12 checks passed
Mishura4 pushed a commit to Mishura4/DPP-PRs that referenced this pull request Sep 17, 2023
@Jaskowicz1 Jaskowicz1 deleted the fixing-issues branch September 20, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants