Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed an issue in embeds.md #836

Closed
wants to merge 3 commits into from
Closed

docs: fixed an issue in embeds.md #836

wants to merge 3 commits into from

Conversation

Jaskowicz1
Copy link
Contributor

This PR fixes an issue in embed.md (This is not covered in #820 so it is safe). Please ignore the other two commits as my fork is broken and can't be fixed until #835 is merged.

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

@netlify
Copy link

netlify bot commented Sep 2, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit a804eaf
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/64f3a05e861d5c0008600a9f
😎 Deploy Preview https://deploy-preview-836--dpp-dev.netlify.app/embed-message
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jaskowicz1
Copy link
Contributor Author

Closed PR so GiovanniRaseraF can do the PR instead (as requested via giscus).

@Jaskowicz1 Jaskowicz1 closed this Sep 2, 2023
@Jaskowicz1 Jaskowicz1 deleted the embed-fix branch September 2, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant