Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update DetectArchitecture.cmake to only search for required CPU-flags. #816

Merged
merged 4 commits into from
Aug 28, 2023

Conversation

RealTimeChris
Copy link
Member

Instead of also searching for bmi and pclmul - which are not required for this implementation.

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

Instead of also searching for bmi and pclmul - which are not required for this implementation.
@CLAassistant
Copy link

CLAassistant commented Aug 28, 2023

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit e92b727
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/64ed1426efe5f300085343dc
😎 Deploy Preview https://deploy-preview-816--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis braindigitalis changed the title Update DetectArchitecture.cmake to only search for required CPU-flags. fix: Update DetectArchitecture.cmake to only search for required CPU-flags. Aug 28, 2023
@braindigitalis braindigitalis merged commit d3884ca into dev Aug 28, 2023
47 of 48 checks passed
@RealTimeChris RealTimeChris deleted the RealTimeChris-patch-1 branch August 30, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants