-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(coro): deprecate sync methods when DPP_CORO is enabled #812
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
not sure I like this idea, as there are tons of bots using sync calls |
We actively discourage using sync already, so the point is that they shouldn't, isn't it? |
that is true but we won't actually be removing them, the lib itself actively uses a couple of sync methods on startup to get number of shards etc. |
I'll change it in the next few days |
Wait i didn't mean to close it lmao |
(The plan is still to change the warning very soon) |
dev
branch.