Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(coro): deprecate sync methods when DPP_CORO is enabled #812

Closed
wants to merge 1 commit into from

Conversation

Mishura4
Copy link
Member

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

@netlify
Copy link

netlify bot commented Aug 26, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit e0f1bd9
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/64ea861baa074e00089ec510
😎 Deploy Preview https://deploy-preview-812--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mishura4 Mishura4 marked this pull request as ready for review August 26, 2023 23:10
@braindigitalis
Copy link
Contributor

not sure I like this idea, as there are tons of bots using sync calls

@Mishura4
Copy link
Member Author

We actively discourage using sync already, so the point is that they shouldn't, isn't it?

@braindigitalis
Copy link
Contributor

that is true but we won't actually be removing them, the lib itself actively uses a couple of sync methods on startup to get number of shards etc.

@Mishura4
Copy link
Member Author

I'll change it in the next few days

@Mishura4 Mishura4 closed this Aug 28, 2023
@Mishura4 Mishura4 deleted the coroutine branch August 28, 2023 21:58
@Mishura4
Copy link
Member Author

Wait i didn't mean to close it lmao

@Mishura4 Mishura4 restored the coroutine branch August 28, 2023 22:05
@Mishura4 Mishura4 reopened this Aug 28, 2023
@Mishura4
Copy link
Member Author

(The plan is still to change the warning very soon)

@Mishura4 Mishura4 marked this pull request as draft August 28, 2023 22:07
@Mishura4 Mishura4 closed this Aug 30, 2023
@Mishura4 Mishura4 deleted the coroutine branch August 30, 2023 15:06
@Mishura4 Mishura4 restored the coroutine branch August 30, 2023 15:07
@Mishura4 Mishura4 deleted the coroutine branch September 17, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants