Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] unicode_emoji.h now compiles properly #806

Merged
merged 2 commits into from
Aug 30, 2023
Merged

[fix] unicode_emoji.h now compiles properly #806

merged 2 commits into from
Aug 30, 2023

Conversation

raxyte
Copy link
Contributor

@raxyte raxyte commented Aug 25, 2023

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

@netlify
Copy link

netlify bot commented Aug 25, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 62288e4
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/64ef17fc6114f200089f5442
😎 Deploy Preview https://deploy-preview-806--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mishura4
Copy link
Member

Mishura4 commented Aug 25, 2023

Does it btw (that would have been a problem before this PR as well)

@raxyte raxyte marked this pull request as draft August 25, 2023 16:14
@Mishura4
Copy link
Member

Actually, all the variables will also need to be inline so as to not cause ODR violations if included in multiple TUs

@braindigitalis
Copy link
Contributor

braindigitalis commented Aug 28, 2023

i will merge this and create a second PR off the back of this that fixes the invalid symbol names. - if everyone is in agreement?

@braindigitalis braindigitalis marked this pull request as ready for review August 30, 2023 10:20
@braindigitalis braindigitalis merged commit f64fc63 into brainboxdotcc:dev Aug 30, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants