Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Created a page for automating builds with Jenkins. #783

Merged
merged 5 commits into from
Aug 20, 2023
Merged

docs: Created a page for automating builds with Jenkins. #783

merged 5 commits into from
Aug 20, 2023

Conversation

Jaskowicz1
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 commented Aug 19, 2023

This PR creates a page all about automating CMake builds with Jenkins. This page is located within "Advanced Reference"

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.
  • I agree to the terms of the DCO (Developer Certificate of Origin)

collect_reactions never used "override" with virtual void completed(), this changes that. Whilst it's not needed, it's better to be explicit.

This also clears a questionable indent on line 36.
@netlify
Copy link

netlify bot commented Aug 19, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 1dcac30
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/64e1243fef8b660008d62f5f
😎 Deploy Preview https://deploy-preview-783--dpp-dev.netlify.app/automating-with-jenkins
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jaskowicz1
Copy link
Contributor Author

GitHub let me merge the branches so PR #780 is no longer involved with this.

@braindigitalis braindigitalis merged commit 118f362 into brainboxdotcc:dev Aug 20, 2023
10 checks passed
@Jaskowicz1 Jaskowicz1 deleted the Jenkins-Automation branch August 20, 2023 08:46
@Commandserver Commandserver added the documentation Improvements or additions to documentation label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants