Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/no user join ready dave #1289

Merged

Conversation

Neko-Life
Copy link
Member

@Neko-Life Neko-Life commented Oct 17, 2024

Draft

  • BREAKING CHANGE: Remove unused ancient event router from unknown origin on_voice_user_talking
  • Fix ready event not firing when no user is in the voice channel
  • Implement opus stop frames for smooth pause/stop

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@Neko-Life Neko-Life marked this pull request as draft October 17, 2024 17:35
@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 17, 2024
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit d906a57
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/67149b6db19e9700088b0d57
😎 Deploy Preview https://deploy-preview-1289--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis
Copy link
Contributor

one thing for your to-do, it fails when you build without voice as you need to change the signature in src/dpp/voice/stubs

@Neko-Life Neko-Life marked this pull request as ready for review October 20, 2024 03:33
@Neko-Life Neko-Life marked this pull request as draft October 20, 2024 05:32
@Neko-Life Neko-Life marked this pull request as ready for review October 20, 2024 05:56
@braindigitalis braindigitalis merged commit 3d24041 into brainboxdotcc:dev Oct 20, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants