Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: why you so salty? Entirely remove libsodium from D++ #1265

Merged
merged 6 commits into from
Oct 11, 2024

Conversation

braindigitalis
Copy link
Contributor

This PR completely removes libsodium as a dependency for voice in D++. No longer do we have to be all salty.
The replement uses OpenSSL primitives instead, plus a pair of functions i lifted from BoringSSL (due credit given) and converted from ugly macros to constexpr.

All build systems that look for and include/link sodium have been adjusted to remove it from the library. All documentation no longer refers to sodium. Note that we do keep previous verisons documentation which will still correctly refer to sodium for those versions.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

Note: GPT used to help explain what HChaCha20 actually is and its role in nonce expansion. Some of the comment docblocks have their origin from the evil AI.

@braindigitalis braindigitalis self-assigned this Oct 11, 2024
Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 24e6fc4
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/67087341399ebe000891cee0
😎 Deploy Preview https://deploy-preview-1265--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis braindigitalis added documentation Improvements or additions to documentation audio audio issues or feature requests dependencies Pull requests that update a dependency file hacktoberfest-accepted Issues tagged for hacktoberfest labels Oct 11, 2024
@github-actions github-actions bot added github_actions Pull requests that update GitHub Actions code build Issue or Pull Request related to the build process code Improvements or additions to code. packaging labels Oct 11, 2024
@Jaskowicz1
Copy link
Contributor

Why so serious?

@braindigitalis
Copy link
Contributor Author

the-dark-knight-joker-2008joker

@braindigitalis braindigitalis merged commit 74db5ee into dev Oct 11, 2024
91 checks passed
@braindigitalis braindigitalis deleted the y-r-u-so-salty branch October 11, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio audio issues or feature requests build Issue or Pull Request related to the build process code Improvements or additions to code. dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code hacktoberfest-accepted Issues tagged for hacktoberfest packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants