Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: readability changes to sslclient and wsclient #1210

Merged
merged 5 commits into from
Jul 24, 2024
Merged

refactor: readability changes to sslclient and wsclient #1210

merged 5 commits into from
Jul 24, 2024

Conversation

Jaskowicz1
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 commented Jul 23, 2024 •
edited
Loading

This PR aims to make sslclient.cpp and wsclient.cpp more readable, making it easier to maintain. There are also a couple of extra improvements (moving from #define to constexpr for example).

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify Netlify
Copy link

netlify bot commented Jul 23, 2024 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit bf67165
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/66a0dd09b14e05000800f69b
😎 Deploy Preview https://deploy-preview-1210--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Jul 23, 2024
@Jaskowicz1 Jaskowicz1 marked this pull request as ready for review July 24, 2024 11:19
@braindigitalis braindigitalis merged commit 0ddf5e2 into dev Jul 24, 2024
89 of 90 checks passed
@braindigitalis braindigitalis deleted the sslclient_changes branch July 24, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braindigitalis braindigitalis braindigitalis approved these changes

Assignees
No one assigned
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaskowicz1 @braindigitalis