Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: big number implementation, for future use in permissions bitfields #1176

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

braindigitalis
Copy link
Contributor

Officially, the Discord documentation says that permission values can be any arbitrary number of digits. At time of writing there are only 50 bits of permissions, but this is set to grow larger and potentially past 64 bits. They will continue to send this data as a huge single integer at that point, because this is obviously sensible. /s

dpp::bignumber uses OpenSSL BN_* under the hood, as we include openssl anyway for HTTPS.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@braindigitalis braindigitalis added the enhancement New feature or request label Jun 19, 2024
@braindigitalis braindigitalis self-assigned this Jun 19, 2024
Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 2dc648c
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6673e9f8e3f41b0008030e95
😎 Deploy Preview https://deploy-preview-1176--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Jun 19, 2024
src/dpp/bignum.cpp Outdated Show resolved Hide resolved
src/dpp/bignum.cpp Outdated Show resolved Hide resolved
src/dpp/bignum.cpp Outdated Show resolved Hide resolved
@Mishura4 Mishura4 changed the title big number implementation, for future use in permissions bitfields feat: big number implementation, for future use in permissions bitfields Jun 20, 2024
@braindigitalis braindigitalis merged commit 46ae489 into dev Jun 20, 2024
75 of 76 checks passed
@braindigitalis braindigitalis deleted the bignum-ssl branch October 11, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants