Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/uncleared track meta on stop audio #1127

Merged

Conversation

Neko-Life
Copy link
Member

Changes in this PR

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@github-actions github-actions bot added the code Improvements or additions to code. label Apr 13, 2024
Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 6da82e2
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/663258f5b44cb900086950e5
😎 Deploy Preview https://deploy-preview-1127--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/dpp/discordvoiceclient.cpp Outdated Show resolved Hide resolved
@Neko-Life Neko-Life force-pushed the fix/uncleared-track-meta-on-stop-audio branch from b4ec0e6 to 4574a78 Compare April 28, 2024 08:26
Copy link
Member

@Mishura4 Mishura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/dpp/discordvoiceclient.cpp Outdated Show resolved Hide resolved
src/dpp/discordvoiceclient.cpp Outdated Show resolved Hide resolved
Copy link
Member

@Mishura4 Mishura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM ship it

@Mishura4 Mishura4 requested a review from Jaskowicz1 May 1, 2024 16:32
@Mishura4
Copy link
Member

Mishura4 commented May 1, 2024

@Jaskowicz1

@Mishura4 Mishura4 merged commit 698c14f into brainboxdotcc:dev May 1, 2024
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants