Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform() of XMLTools doesn't work if source doesn't have a systemID #4

Open
joeha480 opened this issue Jan 30, 2018 · 0 comments
Open
Labels

Comments

@joeha480
Copy link
Contributor

If no systemID is set for the source, no transform is performed. While it is a good idea to set a system id, the transform should still happen, or an exception should be thrown at least.

There is an if statement that requires a systemID to be set here:
https://github.com/brailleapps/dotify.common/blob/master/src/org/daisy/dotify/common/xml/XMLTools.java#L341

If this if-statement is not true, nothing happens. (Wow!)

@joeha480 joeha480 added the bug label Apr 12, 2018
joeha480 added a commit that referenced this issue May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant