Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged this two ifs:
if(!pOnE) outputSum-= kp * dInput;
into this one:
I expect a performance improvement by the if reduction, or am I missing something?
I also separated the derivative computing from the ouputSum merging to add comments to indicate where each parameter is being computed.
Changed this:
into this:
I believe it will compile the same, whether is separated or not. But if you don't like this part I'll remake the PR to remove this.