Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summarize non-content-checked replies in report #10

Open
mthuurne opened this issue Feb 21, 2019 · 1 comment
Open

Summarize non-content-checked replies in report #10

mthuurne opened this issue Feb 21, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@mthuurne
Copy link
Member

It would be useful to show, at the top of the report, how many replies did not have their content checked. Preferably split by reason.

Possible reasons for skipping a content check include:

  • content checks were disabled for the received HTTP status code
  • no content checker was available or enabled for the returned content type
@mthuurne mthuurne added the enhancement New feature or request label Feb 21, 2019
@mthuurne mthuurne changed the title Summarize non-content checked replies in report Summarize non-content-checked replies in report Feb 21, 2019
@mthuurne
Copy link
Member Author

mthuurne commented Oct 3, 2019

Pages for which none of the queries were content-checked could be categorized as "skipped" in the JUnit XML report.

The field Report.checked could be used to track whether a query was content-checked, but it is currently set to True if content checking is disabled for the returned HTTP status code, which contradicts its name. I think that what Report.checked is actually used for at the moment is avoiding a redundant message in the report if a specific reason was logged earlier.

mthuurne added a commit that referenced this issue Oct 14, 2019
See discussion of issue #10. This doesn't implement that enhancement,
but it does prepare the code for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant