BranchService Circular Dependency Fix #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hylstonnb
commented
Jul 28, 2023
webapp/src/main/java/com/box/l10n/mojito/boxsdk/BoxSDKServiceConfigProvider.java
Outdated
Show resolved
Hide resolved
aurambaj
reviewed
Jul 28, 2023
There was a problem hiding this comment.
@hylstonnb Can you please split into 2 PRs: one for the branch service, and 1 for the BoxSDK?
sure, this one now just contains the one related to the BranchService |
aurambaj
reviewed
Jul 28, 2023
webapp/src/main/java/com/box/l10n/mojito/service/branch/DeleteBranchService.java
Show resolved
Hide resolved
hylstonnb
changed the title
unit test fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed circular dependency related to BranchService class.