Add tmTextUnitVariantId in the leveraging message #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurambaj
force-pushed
the
ja/leveraging_comment
branch
2 times, most recently
from
8d2f620
to
e8a2f28
Compare
Previously, it was recording only the tmTextUnitVariantId. It was not explicit so one add to know which "id" it was. In addition, there was no way to search by that "tmTextUnitVariantId" in the workbench. As such it could be only used when looking at the database. It now records the tmTextUnitId and tmTextUnitVariantId. Search by "tmTextUnitId" is possible in the current UI/workbench. A good follow up, will be to be able to search by tmTextUnitVariantId in the workbench too.
aurambaj
force-pushed
the
ja/leveraging_comment
branch
from
e8a2f28
to
c075bb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tmTextUnitVariantId in the leveraging message
Previously, it was recording only the tmTextUnitVariantId. It was not explicit so one add to know which "id" it was. In addition, there is no way to search by that "tmTextUnitVariantId" in the workbench. As such it could be only used when looking at the database.
It now records the tmTextUnitId and tmTextUnitVariantId. Search by "tmTextUnitId" is possible in the current UI/workbench.
A good follow up, will be to be able to search by tmTextUnitVariantId in the workbench too.
Old message in the workbench:
