-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Futures for Images #720
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which datasets has this been tested on?
I tested this on gerrard-hall-100 and skydio-32 datasets. We already use futures for corresponder generator images. This PR also makes it more consistent to use futures in scene-optimizer. |
@stepanyanhayk is there any performance implication from this? |
When running on cluster, I was seeing data reading errors (happening nondeterministically), using futures in all places for data reading seems to fix the issue. |
could you test on skydio-500 or whatever the largest dataset that we have? I am wondering if we will run out of CPU memory for large datasets. |
It would also be great if you looked at the dashboard and verified how the memory is being managed as the images are being loaded. Good to understand whether all images are being loaded at once? is there a peak memory usage there? |
No description provided.