Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Futures for Images #720

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use Futures for Images #720

wants to merge 3 commits into from

Conversation

stepanyanhayk
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@akshay-krishnan akshay-krishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which datasets has this been tested on?

@stepanyanhayk
Copy link
Collaborator Author

which datasets has this been tested on?

I tested this on gerrard-hall-100 and skydio-32 datasets. We already use futures for corresponder generator images. This PR also makes it more consistent to use futures in scene-optimizer.

@ayushbaid
Copy link
Contributor

@stepanyanhayk is there any performance implication from this?

@stepanyanhayk
Copy link
Collaborator Author

stepanyanhayk commented Oct 1, 2023

@stepanyanhayk is there any performance implication from this?

When running on cluster, I was seeing data reading errors (happening nondeterministically), using futures in all places for data reading seems to fix the issue.

@akshay-krishnan
Copy link
Collaborator

which datasets has this been tested on?

I tested this on gerrard-hall-100 and skydio-32 datasets. We already use futures for corresponder generator images. This PR also makes it more consistent to use futures in scene-optimizer.

could you test on skydio-500 or whatever the largest dataset that we have? I am wondering if we will run out of CPU memory for large datasets.

@akshay-krishnan
Copy link
Collaborator

It would also be great if you looked at the dashboard and verified how the memory is being managed as the images are being loaded. Good to understand whether all images are being loaded at once? is there a peak memory usage there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants