Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pruning #1862

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Fix Pruning #1862

merged 7 commits into from
Oct 7, 2024

Conversation

varunagrawal
Copy link
Collaborator

@varunagrawal varunagrawal commented Oct 6, 2024

Update the return value of pruned factors/conditionals to return ∞ as the error in negative log space.

This way, when we normalize (by subtracting the minimum value) and take the exponential negative exp(-e), we get p=0 for pruned assignments, valid probabilities everywhere else.

With this fix, we can now run hybrid legged state estimation for 16 timesteps in 3.8 seconds, down from 13 minutes.

@varunagrawal varunagrawal self-assigned this Oct 6, 2024
Base automatically changed from feature/posteriors to develop October 6, 2024 17:05
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Might want to update the PR comment with what you told me in email. Also, a test that fails before but works after would be great, so future PR’s don’t mess this up.

@varunagrawal
Copy link
Collaborator Author

Added a test which originally fails, and found another subtle bug which I added a fix for.
Furthermore, improved testHybridEstimation.cpp quite a bit.

@varunagrawal varunagrawal merged commit 498d0b3 into develop Oct 7, 2024
33 checks passed
@varunagrawal varunagrawal deleted the fix-pruning branch October 7, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants