Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split DynamicsGraph into separate files #3

Open
gchenfc opened this issue Aug 31, 2020 · 3 comments
Open

Split DynamicsGraph into separate files #3

gchenfc opened this issue Aug 31, 2020 · 3 comments
Assignees

Comments

@gchenfc
Copy link
Member

gchenfc commented Aug 31, 2020

This issue was imported from github.gatech.edu.
The original issue was opened by @aescontrela3 on 2020-02-18T06:02:54Z and assigned to @yzhang3333 @aescontrela3 @smccormick32

Currently, DynamicsGraph is bloated and complex, containing code for trajectory optimization, graph visualization, single timestep dynamics graphs, etc. To decrease code complexity this class should be split up into multiple classes and perhaps some utility files.

I agree. @yzhang3333 have discussed splitting DynamicsGraph into multiple separate files (e.g. trajectory stuff, dynamics graph stuff, etc.), but those changes are out of the scope of this PR. I'll make an issue regarding this.

Originally posted by @aescontrela3 in https://github.gatech.edu/borglab/GTDynamics/pull/6/review_comment/create

@varunagrawal
Copy link
Collaborator

@yetongumich can you tackle this soon? I need to use the dynamics graph for something I'm trying and would like to avoid merge conflicts.

@yetongumich
Copy link
Collaborator

@yetongumich can you tackle this soon? I need to use the dynamics graph for something I'm trying and would like to avoid merge conflicts.

Yes, I'll get it done before next Tuesday.

@varunagrawal
Copy link
Collaborator

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants