Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file:// urls and relative paths #23

Open
ThomasWaldmann opened this issue Sep 10, 2024 · 1 comment
Open

file:// urls and relative paths #23

ThomasWaldmann opened this issue Sep 10, 2024 · 1 comment
Milestone
0.1.0

Comments

@ThomasWaldmann
Copy link
Member

See: borgbackup/borg#8372
ThomasWaldmann added a commit that referenced this issue Sep 10, 2024
@ThomasWaldmann
posixfs: also accept relative paths, see #23
9ad608a 
URLS now might look like:
- file:///absolute/path
- file://relative/path (*)

Internally, PosixFS now:
- accepts relative paths as path argument
- always works with an absolute .base_path internally

(*) not sure if that is the final solution, consider
this as a temporary hack.
@ThomasWaldmann ThomasWaldmann added this to the 0.0.2 milestone Sep 10, 2024
@ThomasWaldmann ThomasWaldmann self-assigned this Sep 10, 2024
ThomasWaldmann added a commit that referenced this issue Sep 10, 2024
@ThomasWaldmann
posixfs: also accept relative paths, see #23
8e51cad 
URLS now might look like:
- file:///absolute/path
- file://relative/path (*)

Internally, PosixFS now:
- accepts relative paths as path argument
- always works with an absolute .base_path internally

(*) not sure if that is the final solution, consider
this as a temporary hack.
@ThomasWaldmann
Copy link
Member Author

ThomasWaldmann commented Sep 10, 2024 •
edited
Loading

added a temporary hack to 0.0.2 release.

borgbackup 2.0.0b10 relies on this hack, so we need to keep it for 0.0.x releases of borgstore.

the fix should be in a later borgbackup beta that requires borgstore ~= 0.1.0.

@ThomasWaldmann ThomasWaldmann modified the milestones: 0.0.2, 0.1.0 Sep 10, 2024
@ThomasWaldmann ThomasWaldmann removed their assignment Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
1 participant
@ThomasWaldmann