Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable a dynamic target lookup #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

enable a dynamic target lookup #28

wants to merge 2 commits into from

Conversation

mabels
Copy link

@mabels mabels commented Aug 24, 2022

Added the a annotation to ingressroute to enable a dynamic target lookup

switchboard.borchero.com/target

  1. a comma seperated list of ip number ipv4 ipv6 [1.1.1.1,1::1]
  2. one domain name [cname.example.cname]
  3. service key like k8snamespace/svcname or svcname than the
    integrations.externalDNS.targetService.namespace is used

…kup.

  switchboard.borchero.com/target

 1. a comma seperated list of ip number ipv4 ipv6 [1.1.1.1,1::1]
 2. one domain name [cname.example.cname]
 3. service key like k8snamespace/svcname or svcname than the
     integrations.externalDNS.targetService.namespace is used
Copy link
Owner

@borchero borchero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @mabels! I briefly skimmed over it and left two comments.

In general, I would appreciate if you could give some more context regarding the motivation behind this PR. Once I know what problem you're trying to solve, I'll be able to do a more proper review.

internal/switchboard/targets.go Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
@mabels
Copy link
Author

mabels commented Aug 28, 2022

My motivation to this fix came from the following setup:

one ingress controller with two nlb why two:

The external is used for the external endpoints and the internal is used my internalone.
Both are getting names from aws so i have to the possibiliy to write two ingressroutes which are using different services to identify there targets.

   * remove the mabels/ipaddress dependency
   * use the zap logger rightly
@AmilcarM11
Copy link

My motivation to this fix came from the following setup:

one ingress controller with two nlb why two:

The external is used for the external endpoints and the internal is used my internalone. Both are getting names from aws so i have to the possibility to write two ingressroutes which are using different services to identify there targets.

Hello, I'm interested in this exact behavior.

Is there any chance of this PR to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants