Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All DropTargets must include field names for proper validation #27

Closed
schanzer opened this issue Apr 9, 2021 · 0 comments
Closed

All DropTargets must include field names for proper validation #27

schanzer opened this issue Apr 9, 2021 · 0 comments

Comments

@schanzer
Copy link
Member

schanzer commented Apr 9, 2021

CMB requires that every dropTarget include a field property, which tells CMB which field in the containing block is associated with that target. Previously, the production version of CMB stripped out these warnings, which is why no one noticed the problem. This has now been fixed, and we get warnings...all the time. :)

Without these fields, CMB has no way to know what to do update, so sometimes updates appear to be no-ops. Other times, they might update the wrong field, or more than one! (See #21 and #19)

The solution is to go through the custom AST nodes in src/languages/pyret/ast.tsx, and make sure every target has a field.

@schanzer schanzer closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant