From 9a906e2f540680ff35a20207f9a1a9a3b889f52b Mon Sep 17 00:00:00 2001 From: Andrey Semashev Date: Thu, 13 Jun 2024 21:25:00 +0300 Subject: [PATCH] Expanded comment re. windres.exe workaround. --- CMakeLists.txt | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index b26c893c1..ba2f46fd2 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -273,7 +273,14 @@ if (WIN32) set_source_files_properties("${CMAKE_CURRENT_BINARY_DIR}/src/windows/simple_event_log.rc" PROPERTIES GENERATED TRUE) if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU") - # Workaround for a windres.exe issue: https://github.com/boostorg/log/pull/231 + # Workaround for a windres.exe issue on MinGW-w64: by default, it uses popen to pipe preprocessed + # output from the preprocessor, but popen is buggy on non-English Windows systems and causes + # compilation errors such as: + # + # windres.exe: can't open file `page:': Invalid argument + # + # This option forces windres.exe to use a temporary file instead. + # https://github.com/boostorg/log/pull/231 list(APPEND CMAKE_RC_FLAGS "--use-temp-file") endif()