Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build script relies on third party to import Context before Fiber #305

Open
Kojoley opened this issue May 1, 2023 · 0 comments
Open

Build script relies on third party to import Context before Fiber #305

Kojoley opened this issue May 1, 2023 · 0 comments

Comments

@Kojoley
Copy link

Kojoley commented May 1, 2023

Fiber build script uses <segmented-stacks> feature

fiber/build/Jamfile.v2

Lines 23 to 26 in 2cb72f5

<target-os>linux,<toolset>gcc,<segmented-stacks>on:<cxxflags>-fsplit-stack
<target-os>linux,<toolset>gcc,<segmented-stacks>on:<cxxflags>-DBOOST_USE_SEGMENTED_STACKS
<toolset>clang,<segmented-stacks>on:<cxxflags>-fsplit-stack
<toolset>clang,<segmented-stacks>on:<cxxflags>-DBOOST_USE_SEGMENTED_STACKS
which is defined in Context library build script. It works currently by pure luck that boost-cpp.jam (main Boost build script) was unintentionally consistently importing Context before Fiber.

Possible solutions:

  1. If -fsplit-stack -DBOOST_USE_SEGMENTED_STACKS is not needed by Fiber itself -- we can just delete these lines and issue will be resolved.
  2. If -fsplit-stack -DBOOST_USE_SEGMENTED_STACKS is needed by Fiber -- we can put there in Context usage requirements and Fiber will get them automatically by using <library>/boost/context//boost_context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant