Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Content update comments" action: extract the code in a real action to ease the maintenance #766

Closed
tbouffard opened this issue Aug 14, 2024 · 0 comments
Closed

"Content update comments" action: extract the code in a real action to ease the maintenance #766

tbouffard opened this issue Aug 14, 2024 · 0 comments
Assignees
@benjaminParisel
Labels
CI ⚙️

Comments

@tbouffard
Copy link
Member

tbouffard commented Aug 14, 2024 •
edited
Loading

Currently, the action is implemented directly in this repository as a mix of composite action and JS script called by the github-script action.
We often see bug like #732 or #759, mainly because the action has not tests.

We should extract it from this repository to ease the maintenance, as we did for the "Antora contribution checkers" action.
We could store it in https://github.com/bonitasoft/actions.
This will let us migrate the code to JS/TS, share the updated files detection with "Antora contribution checkers" action, add tests, ...

Notes

This is probably required prior adding more feature to the existing action, like #677
This was referenced Aug 14, 2024
Open
Closed
benjaminParisel added a commit that referenced this issue Sep 18, 2024
@benjaminParisel
feat: use pr-comments-with-links from actions repository
9d4eabd 
Update the reusaable workflow to use the pr-comments-with-links action from the actions repository.

Covers #766
@benjaminParisel benjaminParisel mentioned this issue Sep 18, 2024
Merged
benjaminParisel added a commit that referenced this issue Sep 18, 2024
@benjaminParisel
feat: use pr-comments-with-links from actions repository
bed8d69 
Update the reusaable workflow to use the pr-comments-with-links action from the actions repository.

Covers #766
@benjaminParisel benjaminParisel self-assigned this Sep 18, 2024
@benjaminParisel benjaminParisel mentioned this issue Sep 18, 2024
Merged
benjaminParisel added a commit to bonitasoft/actions that referenced this issue Sep 19, 2024
@benjaminParisel
feat: prepare action comments with links (#136)
ae48e3d 
For pr-comments-with-links action, we extract the code in a real action
to ease the maintenance.

With this PR, we are as isofunctional as we have actually (with at least
some unit test)

Cover bonitasoft/bonita-documentation-site#766
benjaminParisel added a commit that referenced this issue Sep 23, 2024
@benjaminParisel
feat: use pr-comments-with-links from actions repository (#787)
c722b8e 
Update the reusaable workflow to use the pr-comments-with-links action
from the actions repository.

Covers
#766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjaminParisel benjaminParisel

Labels
CI ⚙️
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjaminParisel @tbouffard