Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

og:image not filled when field type is imagelist #74

Open
thecb1 opened this issue Apr 3, 2019 · 1 comment
Open

og:image not filled when field type is imagelist #74

thecb1 opened this issue Apr 3, 2019 · 1 comment

Comments

@thecb1
Copy link

thecb1 commented Apr 3, 2019

findImageHelper() does not pick up imagelist-fields.

@thecb1
Copy link
Author

thecb1 commented Apr 3, 2019

seo/src/SEO.php

Lines 352 to 355 in 56bc088

} elseif ($field['type'] == 'imagelist') {
if (isset($field[0]['filename'])) {
$image = $field[0]['filename'];
}

Could be fixed with

        } elseif ($field['type'] == 'imagelist') {
            if($imageField === null){
                $imageField = $this->record->values[$fieldname];
            }
            if (isset($imageField[0]['filename'])) {
                $image = $imageField[0]['filename'];
            }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant