This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Proper transactions #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Paranaix - thanks for the contribution! I'd be happy to merge, but I think the tests on CI are failing with these changes (though at first glance, I think it's just a linting issue). |
|
Sorry for the late reply, I was kind of the busy. I already fixed this; however I ammended the commit and did a force push. Unfortunately travis CI doesn't seem to recognize the new commit. If you take a look at the travis build you will see that it still shows 5508348 and not 8310e31. You can checkout the PR yourself and run the tests manually and they should pass IIRC. |
|
Hey @Paranaix - I think there are still a few issues. For instance this line still imports |
|
Ok, I'll have another look at it today or tommorrow |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised: Transactions which actually run in db threads. Supports fake nesting, SAVEPOINTs and can be used as context managers.