Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on not auto-filling username #792

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Work on not auto-filling username #792

merged 3 commits into from
Oct 2, 2024

Conversation

jwlodek
Copy link
Member

@jwlodek jwlodek commented Oct 1, 2024

Checklist

  • Add a Changelog entry
  • Add the ticket number which this PR closes to the comment section

#790

danielballan
danielballan requested changes Oct 1, 2024
View reviewed changes
Copy link
Member

@danielballan danielballan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast turn-around. This looks good. Tested interactively, found one trivial issue. Once addressed, this is good to go.

tiled/client/context.py Outdated Show resolved Hide resolved
@danielballan danielballan merged commit 3fda02e into bluesky:main Oct 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielballan danielballan danielballan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwlodek @danielballan