Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide float format specifier where previously implied (as integer) #903

Merged
merged 1 commit into from
Sep 4, 2020
Merged

provide float format specifier where previously implied (as integer) #903

merged 1 commit into from
Sep 4, 2020

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented Sep 4, 2020

fixes #902

@prjemian prjemian added the bug label Sep 4, 2020
@tacaswell
Copy link
Contributor

Anyone (including @prjemian ) can merge this when CI is green. I don't think we need to force a test of the integer code path.

@prjemian
Copy link
Contributor Author

prjemian commented Sep 4, 2020

Thanks for the review!

@prjemian prjemian merged commit 7c45af9 into master Sep 4, 2020
@prjemian prjemian deleted the 902-fix-implied-format-specifier branch September 4, 2020 15:23
mrakitin
mrakitin reviewed Sep 4, 2020
View reviewed changes
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrakitin mrakitin mrakitin left review comments

@tacaswell tacaswell tacaswell approved these changes

@danielballan danielballan Awaiting requested review from danielballan

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect format specifier in ophyd.signal._get_with_timeout()
3 participants
@prjemian @tacaswell @mrakitin