Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support telemetry in Ping360 replays #1009

Open
ES-Alexander opened this issue Aug 27, 2021 · 3 comments
Open

Support telemetry in Ping360 replays #1009

ES-Alexander opened this issue Aug 27, 2021 · 3 comments
Labels
enhance good first issue must-have A elemental feature that should have replay

Comments

@ES-Alexander
Copy link
Contributor

Summary

Telemetry should be integrated in replays via tlogs in the same way as live viewing supports it.

Additional information

Live viewing allows auto-rotation via telemetry integration, but it's not possible to link a tlog file when doing replays, so the initial correctly-rotated display can only be seen live. This means visual inspection and analysis after a dive requires recording the screen, which seems unnecessary when both relevant data streams are also already being recorded.

Including telemetry in replays also makes it possible to compare display options given the same set of inputs, which can be important when determining the usefulness of a given setting.

@ES-Alexander ES-Alexander added good-to-have Something to have in some use cases enhance labels Aug 27, 2021
@ES-Alexander
Copy link
Contributor Author

+1 requested in this forum post: https://discuss.bluerobotics.com/t/ping-360-video-overlay/10966

@ES-Alexander
Copy link
Contributor Author

Kind of an alternative approach to #948

@ES-Alexander
Copy link
Contributor Author

As an alternative it may be worth Ping Viewer recording the heading it receives from the autopilot as part of its binary data logs. Maybe we could make a generic "sensor heading" message in the ping-protocol to support this, and just convert the received MAVLink messages to that for logging purposes?

That wouldn't be as temporally accurate as doing a replay from an autopilot DataFlash log, for example, but would at least allow replaying the scan as it was displayed at the time of recording. It could also be useful for more generically supporting other data input types (e.g. if someone wants to manually record their ping data through a script and play it back with Ping Viewer later).

@patrickelectric patrickelectric added must-have A elemental feature that should have good first issue and removed good-to-have Something to have in some use cases labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance good first issue must-have A elemental feature that should have replay
Projects
None yet
Development

No branches or pull requests

2 participants