ping360: update reserved fields #205
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickelectric
force-pushed
the
updates-eliot
branch
from
a182230
to
a2b3b93
Compare
ES-Alexander
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
This looks ok to me :-)
I am a little concerned about future-proofing, because some of the fields (e.g. transmit frequency and sample number) have been defined for our specific sensor rather than being generic protocol things with each sensor defining its own limits, but I'm not sure how feasible that is to change at this stage, since those limits are already in place in Ping Viewer and whatnot anyway, and I'm assuming we don't have a lot of development resources available to work on this at the moment.
jaxxzer
reviewed
Dec 15, 2023
| @@ -87,61 +125,111 @@ | |||
| { | |||
| "name": "gain_setting", | |||
| "type": "u8", | |||
| "description": "Analog gain setting (0 = low, 1 = normal, 2 = high)" | |||
| "description": "Analog gain setting", | |||
| "enum": { | |||
There was a problem hiding this comment.
Can we have a default value with enum?
jaxxzer
reviewed
Dec 15, 2023
| @@ -31,37 +39,67 @@ | |||
| { | |||
| "name": "gain_setting", | |||
| "type": "u8", | |||
| "description": "Analog gain setting (0 = low, 1 = normal, 2 = high)" | |||
| "description": "Analog gain setting", | |||
| "enum": { | |||
jaxxzer
approved these changes
Dec 15, 2023
|
Need to update to support Default values |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #161