ping360 update #161
Open
ping360 update #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickelectric
requested changes
Jul 24, 2019
| @@ -82,12 +105,14 @@ | |||
| { | |||
| "name": "bootloader", | |||
| "type": "u8", | |||
| "description": "0 = skip bootloader; 1 = run bootloader" | |||
| "description": "0 = skip bootloader; 1 = run bootloader", | |||
| "default": "0" | |||
There was a problem hiding this comment.
minimum and maximum are missing here.
There was a problem hiding this comment.
This is not a range value. It is an enumeration. I think range does not make sense here.
There was a problem hiding this comment.
if it's an enum, it's better to use identifiers instead of integers in the json
| }, | ||
| { | ||
| "name": "transmit", | ||
| "type": "u8", | ||
| "description": "0 = do not transmit; 1 = transmit after the transducer has reached the specified angle" | ||
| "description": "0 = do not transmit; 1 = transmit after the transducer has reached the specified angle", | ||
| "default": "0" |
There was a problem hiding this comment.
missing maximum and minimum.
There was a problem hiding this comment.
This is not a range value. It is an enumeration. I think range does not make sense here.
|
Add min/max to common and ping1d. fix #163 |
patrickelectric
approved these changes
Dec 14, 2023
|
I'll try to cherry-pick this and move to fields as suggested by @tcanabrava |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The valid range metadata can go into the documentation, provide constants for sensor class, and make it possible to do runtime validations in templates.