Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

widget-manager: variableName as VeryGenericIndicator widget name #671

Merged
merged 2 commits into from
Jan 4, 2024
Merged

widget-manager: variableName as VeryGenericIndicator widget name #671

merged 2 commits into from
Jan 4, 2024

Conversation

wandersonsousa
Copy link
Contributor

@wandersonsousa wandersonsousa commented Jan 4, 2024 •
edited by ES-Alexander
Loading

Fixes #597

Use the variable name as the widget name on the VeryGenericIndicator

Just added a conditional, to use the variable name if it exists

@CLAassistant
Copy link

CLAassistant commented Jan 4, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@patrickelectric
Copy link
Member

Hi @wandersonsousa thanks for you contribution!
But it appears that there is some style changes required on the code by CI.

@wandersonsousa
Copy link
Contributor Author

Hi @wandersonsousa thanks for you contribution! But it appears that there is some style changes required on the code by CI.

Hello, nice, I will check that

@wandersonsousa
Copy link
Contributor Author

Hi @wandersonsousa thanks for you contribution! But it appears that there is some style changes required on the code by CI.

Fixed

@patrickelectric patrickelectric merged commit 9143aec into bluerobotics:master Jan 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaellehmkuhl rafaellehmkuhl Awaiting requested review from rafaellehmkuhl

@patrickelectric patrickelectric Awaiting requested review from patrickelectric

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the variable name as the widget name on the VeryGenericIndicator
3 participants
@wandersonsousa @CLAassistant @patrickelectric