-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main-vehicle: allow setting vehicle and stream urls via query #669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not working for me.
I've tried accessing a local vehicle (regular URL e.g.: 192.168.0.99) and it didn't connect.
It works fine on master.
Console shows:
WebSocket connection to 'ws://192.168.0.99/ws/mavlink' failed:
It only works if I explicitly set the m2r address as ws://192.168.0.99:6040/ws/mavlink
.
be99cdf
to
858e608
Compare
I'll fix the pr |
858e608
to
4e9aeaf
Compare
e83cdb7
to
6f6dfbb
Compare
6f6dfbb
to
9fcc278
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working like a charm.
Can I merge it @Williangalvani?
it results in some rather ugly urls, but it works 🤷