Try to prevent user from closing Cockpit during video record #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaellehmkuhl
force-pushed
the
warn-before-close
branch
3 times, most recently
from
e8e9c69
to
b35565c
Compare
rafaellehmkuhl
force-pushed
the
warn-before-close
branch
from
b35565c
to
1556adb
Compare
rafaellehmkuhl
force-pushed
the
warn-before-close
branch
from
1556adb
to
aabb54d
Compare
|
|
||
| // Try to prevent user from closing Cockpit when a stream is being recorded | ||
| watch(isRecording, () => { | ||
| if (isRecording.value) { |
There was a problem hiding this comment.
I would recommend doing the reverse logic with early return with onbeforeunload
rafaellehmkuhl
force-pushed
the
warn-before-close
branch
from
aabb54d
to
a7c8c9d
Compare
patrickelectric
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the best we can do for now. Chrome (as most other browsers) do not allow us anymore to set a custom message on the tab-closing alert.
With this patch, it's very unlikely that the user will make the same mistake twice.
A better solution for the future would be to save the recording direct to the user's drive, instead of the memory. I don't know if that's possible or not.
Screen.Recording.2023-10-24.at.16.22.17.mp4
Fix #518