Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network scanner extension #90

Merged
merged 1 commit into from
May 6, 2024

Conversation

Williangalvani
Copy link
Member

This is useful for finding other devices in the networks accessible from the vehicle. such as ethernet-based sensors

This is useful for finding other devices in the networks accessible from the vehicle.
such as ethernet-based sensors
@ES-Alexander
Copy link
Collaborator

Extension seems ok, but the README link in the Dockerfile labels is broken.

Longer term this functionality seems like it could be included in BlueOS core, as a more advanced version of the existing Available Services page (maybe by extending the helper service?), but seems reasonable to allow independently testing it as an Extension for now :-)

@Williangalvani
Copy link
Member Author

Extension seems ok, but the README link in the Dockerfile labels is broken.

Longer term this functionality seems like it could be included in BlueOS core, as a more advanced version of the existing Available Services page (maybe by extending the helper service?), but seems reasonable to allow independently testing it as an Extension for now :-)

good catch, fixed it.

@ES-Alexander ES-Alexander merged commit d0d79a5 into bluerobotics:master May 6, 2024
2 checks passed
@Williangalvani Williangalvani deleted the network-scanner branch May 6, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants